LSTM: Move Wx matrix multiplication out of the loop in forward#187
Open
antihutka wants to merge 1 commit intojcjohnson:masterfrom
Open
LSTM: Move Wx matrix multiplication out of the loop in forward#187antihutka wants to merge 1 commit intojcjohnson:masterfrom
antihutka wants to merge 1 commit intojcjohnson:masterfrom
Conversation
|
I can test GPU execution on CUDA this weekend, can someone check OpenCL? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move one of the
addmmcalls out of the loop and do it in one call across all timesteps. This should provide a significant speedup when running with smallbatch_size.I was able to get 10-20% speedup with
batch_size=8when running on CPU, but I'm unable to test it on GPU at the moment.