Open
Conversation
jbreams
requested changes
Mar 11, 2017
Owner
jbreams
left a comment
jbreams
left a comment
There was a problem hiding this comment.
Looks pretty good, but I have some questions.
item_view.h
Outdated
| } | ||
|
|
||
| void processSingleField(std::string label, std::string value, bool conceal) { | ||
| void processSingleField(std::string label, std::string value, bool conceal, bool copy_button) { |
Owner
There was a problem hiding this comment.
Is this always true? If so, let's not add another parameter.
item_view.h
Outdated
| if (conceal && !isTOTP) | ||
| value_widget->set_visibility(false); | ||
| attach(*value_widget, 1, my_index, conceal ? 1 : 3, 1); | ||
| attach(*value_widget, 1, my_index, conceal || copy_button ? 1 : 3, 1); |
Owner
There was a problem hiding this comment.
I think this becomes attach(*value_widget, 1, my_index, conceal ? 1 : 2, 1);
item_view.h
Outdated
| attach(*value_widget, 1, my_index, conceal || copy_button ? 1 : 3, 1); | ||
|
|
||
| if (conceal) { | ||
| if (copy_button) { |
Owner
There was a problem hiding this comment.
Again, since this is just always true, I don't think it needs to be in a conditional
dpedu
force-pushed
the
dpedu/copy-button
branch
from
ae3b948 to
91bf4b9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found myself selecting and copying username fields manually. So I figured having a copy button on all single text fields could be useful.
I guess it's a bit of an opinion thing whether or not this will merge. The copy_button param of processSingleField decides if the button is added or not, but is hard-coded to
true. Maybe someday user preferences will control it.