Add strict parameter to remove() TaggableManager.remove() method (fixes #928)#937
Open
Dzhud wants to merge 1 commit intojazzband:masterfrom
Open
Add strict parameter to remove() TaggableManager.remove() method (fixes #928)#937Dzhud wants to merge 1 commit intojazzband:masterfrom
Dzhud wants to merge 1 commit intojazzband:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #928
This PR adds an optional strict parameter to the
TaggableManager.remove()method, allowing users to opt-in to receiving an error when attempting to remove tags that are not associated with the object.Changes
managers.py: Addedstrict=Falseparameter toremove()method. Whenstrict=True, raises ValueError listing any tags not found on the object.tests.py: Added 4 test cases covering the new functionality.CHANGELOG.rst: Added entry for the new feature.api.rst: Updated documentation with the new parameter.Behaviour