Ask for consent - Matomo (Continuation Jayhaluska's work) - #245
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #245 +/- ##
==========================================
+ Coverage 94.53% 94.55% +0.02%
==========================================
Files 31 31
Lines 1355 1360 +5
==========================================
+ Hits 1281 1286 +5
Misses 74 74 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Thanks for pushing the changes to the finish line! A few more things before we cross it:
|
I merged the |
|
There's something wrong with what you merged. The merge widget says, "This branch cannot be rebased due to conflicts". Can you please rebase the branch of this PR on top of the main branch of this repo? This will probably force you to resolve some merge conflicts. |
This PR continues Jayhaluska's work. Credit to him for working on this in 2019. For more info, see #142
This PR addresses some comments left by the maintainer, for instance the removal if Piwik and rebased Jayhaluska's branch since their PR is a bit outdated.