Skip to content

Ask for consent - Matomo (Continuation Jayhaluska's work) - #245

Merged
bittner merged 17 commits into
jazzband:mainfrom
ronardcaktus:jayhaluska-master
Mar 8, 2026
Merged

Ask for consent - Matomo (Continuation Jayhaluska's work)#245
bittner merged 17 commits into
jazzband:mainfrom
ronardcaktus:jayhaluska-master

Conversation

@ronardcaktus

@ronardcaktus ronardcaktus commented Feb 19, 2026

Copy link
Copy Markdown
Contributor

This PR continues Jayhaluska's work. Credit to him for working on this in 2019. For more info, see #142

This PR addresses some comments left by the maintainer, for instance the removal if Piwik and rebased Jayhaluska's branch since their PR is a bit outdated.

@codecov

codecov Bot commented Feb 19, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.55%. Comparing base (694fc90) to head (114c65d).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #245      +/-   ##
==========================================
+ Coverage   94.53%   94.55%   +0.02%     
==========================================
  Files          31       31              
  Lines        1355     1360       +5     
==========================================
+ Hits         1281     1286       +5     
  Misses         74       74              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ronardcaktus
ronardcaktus requested a review from bittner February 19, 2026 14:18
Comment thread docs/services/matomo.rst Outdated
Comment thread docs/services/matomo.rst Outdated
Comment thread docs/services/matomo.rst Outdated
Comment thread pyproject.toml Outdated
Comment thread .gitignore Outdated
@ronardcaktus ronardcaktus changed the title Continue Jayhaluska's work Ask for consent - Matomo (Continuation Jayhaluska's work) Feb 21, 2026
@ronardcaktus
ronardcaktus requested a review from bittner February 21, 2026 11:40
@bittner

bittner commented Feb 24, 2026

Copy link
Copy Markdown
Member

Thanks for pushing the changes to the finish line! A few more things before we cross it:

  • You need to rebase the feature branch (or merge the main branch) and resolve the conflicts.
  • Please add yourself and the original author to the list of authors in the pyproject.toml file.
  • Please add a line about your changes to the change log.

@ronardcaktus

Copy link
Copy Markdown
Contributor Author

Thanks for pushing the changes to the finish line! A few more things before we cross it:

  • You need to rebase the feature branch (or merge the main branch) and resolve the conflicts.
  • Please add yourself and the original author to the list of authors in the pyproject.toml file.
  • Please add a line about your changes to the change log.

I merged the main branch on this commit 0e826aa
Changelog and pyproject.toml are updated.

@bittner

bittner commented Feb 25, 2026

Copy link
Copy Markdown
Member

There's something wrong with what you merged. The merge widget says, "This branch cannot be rebased due to conflicts".

Can you please rebase the branch of this PR on top of the main branch of this repo? This will probably force you to resolve some merge conflicts.

@ronardcaktus
ronardcaktus requested a review from bittner February 28, 2026 14:04
@bittner
bittner merged commit e6f1271 into jazzband:main Mar 8, 2026
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants