[Refactor] replace deprecated .value with [...] for nnx variables

[lingebeng]

Inspired by #135

Too many warnings!

nnx.Variable.value is deprecated (DeprecationWarning: '.value' access is now deprecated. For Variable[Array] instances use: variable[...] ...) -> replaced with x[...] in convnext (I haven't searched for other .value usages in the whole codebase)

[google-cla]

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

[gemini-code-assist]

Summary of Changes

Hello @lingebeng, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the codebase to address deprecation warnings related to 'nnx.Variable' access. It systematically replaces all instances of the '.value' attribute with the recommended '[...]' indexing for 'nnx.Variable' objects, ensuring the code adheres to the current 'nnx' API standards. This change impacts several model architectures and their associated test files, improving code maintainability and preventing runtime warnings.

Highlights

• API Deprecation Fix: Replaced deprecated '.value' attribute access for 'nnx.Variable' instances with the new '[...]' indexing syntax across multiple model implementations and test files.
• Code Modernization: Updated code to align with the latest 'nnx' library API, preventing future deprecation warnings and ensuring compatibility.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request correctly replaces the deprecated nnx.Variable.value access with [...]. This resolves the deprecation warnings as intended. I've added a few suggestions to further improve the code by using the proxy features of nnx.Variable more idiomatically. For instance, instead of variable[...][slice], you can use variable[slice] directly, and similarly for attribute access like .shape or method calls like .at. These changes will make the code more concise and readable.

[chapman20j]

Hi @lingebeng. Thank you for opening a PR. We're planning to merge in an updated LLaDA soon. Could you remove those updates from the llada_8b folder? Also, could you address the comments from gemini-code-assist? Thanks!

[lingebeng]

Of course

[jenriver]

Thanks for the refactor!