Fix 'as loaded' sorting in search view#995
Open
antonnyst wants to merge 2 commits into
Open
Conversation
Necessary due to search view using sort field equal to `null` for not sorting
…efault To allow null values in sort options to not be first in list.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to the sort selector returning the default field when value is null it is impossible to select 'as loaded' sorting in the search view, something which was missed after my edit in #976 😅
After some time debugging i figured out the reason and have created this fix. Although i haven't done much extensive testing from a quick look it does not seem to cause any unintended side-effects.