Skip to content

removed a singleton-comparison pitfall - #189

Open
NaelsonDouglas wants to merge 1 commit into
jadore801120:masterfrom
python-pitfalls:master
Open

removed a singleton-comparison pitfall#189
NaelsonDouglas wants to merge 1 commit into
jadore801120:masterfrom
python-pitfalls:master

Conversation

@NaelsonDouglas

@NaelsonDouglas NaelsonDouglas commented Oct 10, 2021

Copy link
Copy Markdown

Problem:
The code had a pitfall known as singleton-comparison.
In Python, when comparing singletons, like None, True or False, it's safer to use the 'is' operator instead of '=='.
Constructions like:

foo == True
bar == False
foobar == None

Are preferred to be written as:

foo is True
bar is False
foobar is None

These discussions give some highlight into this topic
https://stackoverflow.com/questions/1011431/common-pitfalls-in-python
https://stackoverflow.com/questions/2209755/python-operation-vs-is-not

Solution:
This pull request simply removes this pitfall from the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant