Skip to content

fix: tighten internal callback types#1617

Open
jun0315 wants to merge 1 commit into
jackwener:mainfrom
jun0315:fix/internal-any-types
Open

fix: tighten internal callback types#1617
jun0315 wants to merge 1 commit into
jackwener:mainfrom
jun0315:fix/internal-any-types

Conversation

@jun0315
Copy link
Copy Markdown
Contributor

@jun0315 jun0315 commented May 16, 2026

Description

Tighten two internal callback type definitions to avoid unnecessary any[] usage without changing runtime behavior or public APIs.

  • Narrow the local browser eval helper function type from any[] to never[], since the function is serialized rather than invoked in Node.

  • CI / build / tooling

Checklist

  • I ran the checks relevant to this PR

  • I updated tests or docs if needed

  • I included output or screenshots when useful

  • Added doc page under docs/adapters/ (if new adapter)

  • Updated docs/adapters/index.md table (if new adapter)

  • Updated sidebar in docs/.vitepress/config.mts (if new adapter)

  • Updated README.md / README.zh-CN.md when command discoverability changed

  • Used positional args for the command's primary subject unless a named flag is clearly better

  • Normalized expected adapter failures to CliError subclasses instead of raw Error

Screenshots / Output

Result: typecheck passed; 3 test files passed, 186 tests passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant