fix: tighten internal callback types#1617
Open
jun0315 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Tighten two internal callback type definitions to avoid unnecessary
any[]usage without changing runtime behavior or public APIs.Narrow the local browser eval helper function type from
any[]tonever[], since the function is serialized rather than invoked in Node.CI / build / tooling
Checklist
I ran the checks relevant to this PR
I updated tests or docs if needed
I included output or screenshots when useful
Added doc page under
docs/adapters/(if new adapter)Updated
docs/adapters/index.mdtable (if new adapter)Updated sidebar in
docs/.vitepress/config.mts(if new adapter)Updated
README.md/README.zh-CN.mdwhen command discoverability changedUsed positional args for the command's primary subject unless a named flag is clearly better
Normalized expected adapter failures to
CliErrorsubclasses instead of rawErrorScreenshots / Output
Result: typecheck passed; 3 test files passed, 186 tests passed.