Skip to content

refactor(browser): type eval helper callbacks#1616

Open
jun0315 wants to merge 1 commit into
jackwener:mainfrom
jun0315:fix/browser-utils-typing
Open

refactor(browser): type eval helper callbacks#1616
jun0315 wants to merge 1 commit into
jackwener:mainfrom
jun0315:fix/browser-utils-typing

Conversation

@jun0315
Copy link
Copy Markdown
Contributor

@jun0315 jun0315 commented May 16, 2026

Description

Tightens the internal browser eval helper callback type by reusing BrowserEvaluateFunction instead of a local any[] callback signature.

This keeps the existing runtime behavior unchanged while removing one small internal any usage.

  • Bug fix
  • ✨ New feature
  • New site adapter
  • Documentation
  • ♻️ Refactor
  • CI / build / tooling

Checklist

  • I ran the checks relevant to this PR
  • I updated tests or docs if needed
  • I included output or screenshots when useful

Screenshots / Output

npm test -- --project unit src/browser/utils.test.ts
Test Files  1 passed (1)
Tests       5 passed (5)

npm run typecheck -- --incremental false
passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant