Fix: Incorrect mouse position on canvas LWJGL3 (Canvas)#2332
Merged
yaRnMcDonuts merged 4 commits intojMonkeyEngine:masterfrom Feb 16, 2025
Merged
Fix: Incorrect mouse position on canvas LWJGL3 (Canvas)#2332yaRnMcDonuts merged 4 commits intojMonkeyEngine:masterfrom
yaRnMcDonuts merged 4 commits intojMonkeyEngine:masterfrom
Conversation
MeFisto94
reviewed
Dec 29, 2024
Member
MeFisto94
left a comment
MeFisto94
left a comment
There was a problem hiding this comment.
Can't comment on the functionality, probably needs testing, but code wise it looks good
jme3-desktop/src/main/java/com/jme3/input/awt/AwtMouseInput.java
Outdated
Show resolved
Hide resolved
jme3-desktop/src/main/java/com/jme3/input/awt/AwtMouseInput.java
Outdated
Show resolved
Hide resolved
jme3-desktop/src/main/java/com/jme3/input/awt/AwtMouseInput.java
Outdated
Show resolved
Hide resolved
added 3 commits
December 29, 2024 12:36
Member
|
I'll leave this open for another 2-3 day, then I plan to merge this so it can be tested in 3.8 beta. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves bad mouse position when using canvas with lwjgl3, this fixes issue #2327 (Cursor centered on click -> flying camera with
setDragToRotate(true)option enabled).Now when the cursor is grabbed, if there is a point (coordinates) coming from the user, the cursor will stay at that position; otherwise it will focus on the component (canvas).