Correct crash classification for MTE SEGV traces#14
Open
dhavalts1989 wants to merge 1 commit intoittiam-systems:masterfrom
Open
Correct crash classification for MTE SEGV traces#14dhavalts1989 wants to merge 1 commit intoittiam-systems:masterfrom
dhavalts1989 wants to merge 1 commit intoittiam-systems:masterfrom
Conversation
aditya-wazir
requested changes
Oct 10, 2025
Collaborator
There was a problem hiding this comment.
- add comment explaining logic
- Need for else part? How will the generated test case looks for else part? Should write test for else part
- What all kind of crashes will this parsing cover for MTE devices. Add that too
- See if stack trace for other issues is also being processed correctly, if not, lets update that as next commit or PR
- Commit message for the PR that we will push to Google/clusterfuzz will not require ss , need to create a commit message explaining change and the basis we are using to parse these crashes.
Collaborator
Author
There was a problem hiding this comment.
Hi Aditya,
- The updated commit includes a comment clearly explaining the logic for parsing MTE SEGV crashes.
- The else part was not necessary and has been removed in this commit, as the regex match is expected whenever 'SEGV_MTESERR' is present.
- This parsing specifically covers MTE SEGV crashes only. This is mentioned both in the updated code comment and the commit message.
- This change does not affect the parsing of other stack traces. It only processes memory-related errors for MTE devices by checking 'SEGV_MTESERR', which is unique to MTE SEGV crashes.
- The commit message has been updated to explain the logic and the rationale for parsing MTE SEGV crashes.
Please review the latest commit.
dhavalts1989
force-pushed
the
mte_parsing_fix
branch
from
34879d7 to
a63a779
Compare
Collaborator
aditya-wazir
left a comment
aditya-wazir
left a comment
There was a problem hiding this comment.
variable shouldn't be named 'm'. Please rectify
Previously, MTE crashes were incorrectly reported as UNKNOWN. The existing ANDROID_SEGV_REGEX matches MTE SEGV traces but sets new_type=UNKNOWN, causing misclassification. This change adds an explicit check for 'SEGV_MTESERR' in the crash trace line and updates crash_type to "Tag-mismatch" with the correct access type (e.g., "(read)" or "(write)"). The update ensures that crashes involving MTE faults are parsed correctly, filed under the appropriate crash type, and test cases now verify the correct behavior.
dhavalts1989
force-pushed
the
mte_parsing_fix
branch
from
a63a779 to
8f89433
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MTE crashes were incorrectly reported as UNKNOWN. The existing ANDROID_SEGV_REGEX matches MTE SEGV traces but sets new_type=UNKNOWN. The fix checks for SEGV_MTESERR in the trace line and updates crash_type accordingly. Verified locally, test cases are now filed with the correct SEGV_MTESERR crash type.