[10.0] pos_debt_notebook: fix some bugs#1160
Open
alexis-via wants to merge 1 commit intoitpp-labs:10.0from
Open
[10.0] pos_debt_notebook: fix some bugs#1160alexis-via wants to merge 1 commit intoitpp-labs:10.0from
alexis-via wants to merge 1 commit intoitpp-labs:10.0from
Conversation
Contributor
alexis-via
commented
Nov 18, 2019
alexis-via
commented
- create account of debt journal with reconcile=True
- When we have demo data, don't create 2 products with same default_code
- Partial fix for button "Pay Full Debt" on customer list in POS frontend. The feature triggered by a click on that button is still buggy: in some scenarios, the payment line is not created.
When we have demo data, don't create 2 products with same default_code Partial fix for button "Pay Full Debt" on customer list in POS frontend (the method is still buggy: there is a second bug to fix here)
itpp-bot
reviewed
Nov 18, 2019
Contributor
itpp-bot
left a comment
itpp-bot
left a comment
There was a problem hiding this comment.
1 installable module is updated:
└─ pos_debt_notebook/
├─ data/
| └─ demo.xml
├─ models.py
└─ static/
└─ src/
└─ js/
└─ pos.js
Not installable modules remain unchanged.
No new features in doc/changelog.rst files of installable modules
sent by ✌️ Odoo Review Bot
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
| if (order) { | ||
| var lastorderline = order.get_last_orderline(); | ||
| if (lastorderline === null && self.pos.config.debt_dummy_product_id){ | ||
| if (lastorderline === undefined && self.pos.config.debt_dummy_product_id){ |
There was a problem hiding this comment.
Unexpected use of undefined no-undefined
Contributor
Author
|
One thing that I noticed: the button "Pay Full Debt" on customers list is sometimes buggy, but the button "Pay Full Debt" on the payment screen works fine. Note that the code is not the same for those 2 buttons. |
Contributor
Ramil-Mukhametzyanov
left a comment
Ramil-Mukhametzyanov
left a comment
There was a problem hiding this comment.
@alexis-via
Thank you for the pull-request. We'll check it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.