Merged
Conversation
Contributor
|
Для изображений нужно создать отдельную директорию в корне |
ismukhin
reviewed
Feb 23, 2026
| logger.info(f"Launching opencv_sample") | ||
| matcher = FeatureMatcherCV2(args.method) | ||
| if not matcher.load_images(args.image1, args.image2): | ||
| return 1 |
Contributor
There was a problem hiding this comment.
Нужно отлогировать что пошло не так явно
samples/match_cv_scripts.py
Outdated
Comment on lines
+38
to
+39
| target_method = f"{self._method_name.upper()}_create" | ||
| method = getattr(cv, target_method, None) |
Contributor
There was a problem hiding this comment.
На самом деле это не очень хороший подход, потому что не видно явно по коду какой метод мы создаем, плюсом нет гарантий, что всегда верхний регистр у методов. Поэтому здесь предложение создать где-то словарь:
methods = {
'SIFT': cv2.SIFT_create(),
'ORB': cv2.ORB_create(),
}
Contributor
|
Надо подцепить изменения с мастер-ветки в свою мастер-ветку, после чего в текущей ветке opencv_sample сделать git merge https://docs.github.com/ru/pull-requests/collaborating-with-pull-requests/working-with-forks/configuring-a-remote-repository-for-a-fork |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.