Delete simulation error handling and developer guide updates#64
Open
deepakmaroo wants to merge 3 commits intoiterorganization:developfrom
Open
Delete simulation error handling and developer guide updates#64deepakmaroo wants to merge 3 commits intoiterorganization:developfrom
deepakmaroo wants to merge 3 commits intoiterorganization:developfrom
Conversation
deepakmaroo
requested review from
SimonPinches,
Yannicked,
maarten-ic and
olivhoenen
as code owners
olivhoenen
reviewed
May 4, 2026
| @@ -391,7 +392,7 @@ def delete(self, sim_id: str, user: User) -> SimulationDeleteResponse: | |||
| if first_file.uri.path is not None: | |||
| directory = first_file.uri.path.parent | |||
Contributor
There was a problem hiding this comment.
Unless I'm mistaking about the intent for this file/folder removal during the delete, I think this function can be improved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
directory.rmdir()withshutil.rmtree(directory)