Fix docker entrypoint failure when host user is 'ubuntu'#415
Open
jo-fra wants to merge 1 commit intoisaac-sim:release/0.1.1from
Open
Fix docker entrypoint failure when host user is 'ubuntu'#415jo-fra wants to merge 1 commit intoisaac-sim:release/0.1.1from
jo-fra wants to merge 1 commit intoisaac-sim:release/0.1.1from
Conversation
Signed-off-by: jo-fra <69941576+jo-fra@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When the host username is
ubuntu,docker/run_docker.shfails at container startup with:Root Cause
In
entrypoint.sh,groupadd --forceruns beforeuserdel ubuntu. Since the base image already has aubuntuuser/group, the sequence is:groupadd --force— groupubuntualready exists, no-opuserdel ubuntu— deletes the user and its primary groupuseradd --gid ubuntu— fails because the group was removed in step 2Fix
Move
userdelcalls beforegroupadd, so the group is always (re)created after any prior user/group removal.