[Codegen][GPU] Add kernel config for ArgCompareOp with VectorDistribute pipeline #24003
Open
bangtianliu wants to merge 4 commits intoiree-org:mainfrom
Open
[Codegen][GPU] Add kernel config for ArgCompareOp with VectorDistribute pipeline #24003bangtianliu wants to merge 4 commits intoiree-org:mainfrom
bangtianliu wants to merge 4 commits intoiree-org:mainfrom
Conversation
Signed-off-by: Bangtian Liu <liubangtian@gmail.com>
Signed-off-by: Bangtian Liu <liubangtian@gmail.com>
- Extract shared helpers and to deduplicate shape computation logic between DistributeMultiReduction and DistributeArgCompare - Simplify broadcastShape computation by deriving from distributed input shape instead of manual construction - Reuse existing elemTy/indexElemTy variables instead of repeated getElementType() calls - Simplify resultValue initialization by setting common case first - Fix inaccurate comment about yielded value check Signed-off-by: Bangtian Liu <liubangtian@gmail.com>
bangtianliu
requested review from
Groverkss,
Max191,
krzysz00,
kuhar,
nirvedhmeshram and
qedawkins
as code owners
bangtianliu
force-pushed
the
argcompare-kernel-config-v2
branch
3 times, most recently
from
a1125a0 to
f82a041
Compare
…te pipeline Signed-off-by: Bangtian Liu <liubangtian@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds kernel config for
iree_linalg_ext.arg_compareoperations with the VectorDistribute pipeline.Note: Currently rebase on #23793, so please only review last commit.
Issue: #23005
Assisted-by: Claude Code