[SPIRV] Switch SPIR-V to module-scope pipeline.#23998
Open
Conversation
hanhanW
force-pushed
the
users/hanhanW/modernize-gpu-pipeline-tests-v3
branch
from
f50359f to
c3066b5
Compare
hanhanW
force-pushed
the
users/hanhanW/update-spirv-pipeline-order
branch
from
2ba74a2 to
2028e8b
Compare
hanhanW
force-pushed
the
users/hanhanW/modernize-gpu-pipeline-tests-v3
branch
from
c3066b5 to
a678c97
Compare
hanhanW
changed the base branch from
users/hanhanW/modernize-gpu-pipeline-tests-v3
to
users/hanhanW/fix-spirv-convert-gpu-target
Base automatically changed from
users/hanhanW/fix-spirv-convert-gpu-target
to
main
April 3, 2026 19:28
hanhanW
force-pushed
the
users/hanhanW/update-spirv-pipeline-order
branch
from
2028e8b to
20deb6f
Compare
hanhanW
changed the title
Signed-off-by: hanhanW <hanhan0912@gmail.com>
hanhanW
force-pushed
the
users/hanhanW/update-spirv-pipeline-order
branch
from
20deb6f to
0ad12ef
Compare
Contributor
Author
|
Similar to other patches, it is much easier to review the lit tests part, if you enable "hide whitespace" option. 
|
Signed-off-by: hanhanW <hanhan0912@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The revision moves the variant-scope passes to the boundary of pipelines, and the actual codegen works on module-scope after the change. The pipeline tests are adapted, so there are no hal.variant op involved.
It also fixes a long-due TODO in HALInterfaceLoadConstantConverter.