samples: Refactor input handling with data-driven approach#23955
Open
HanKuanChen wants to merge 1 commit intoiree-org:mainfrom
Open
samples: Refactor input handling with data-driven approach#23955HanKuanChen wants to merge 1 commit intoiree-org:mainfrom
HanKuanChen wants to merge 1 commit intoiree-org:mainfrom
Conversation
- Introduce `input_buffer_descriptor_t` struct to describe input buffer metadata (shape, element type, data pointer, size). - Add `push_back_buffer_view()` helper function to encapsulate buffer view allocation and input pushing logic, eliminating code duplication. - Use array of descriptors with a loop to process inputs, making it easier to add or modify inputs without repeating code. This refactoring improves code maintainability and makes it simpler to work with different element types (e.g., float32, float16, uint8). Signed-off-by: Han-Kuan Chen <hankuan.chen@sifive.com>
HanKuanChen
force-pushed
the
refactor-static_library_demo
branch
from
274e321 to
0641dce
Compare
HanKuanChen
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
input_buffer_descriptor_tstruct to describe input buffer metadata (shape, element type, data pointer, size).push_back_buffer_view()helper function to encapsulate buffer view allocation and input pushing logic, eliminating code duplication.This refactoring improves code maintainability and makes it simpler to work with different element types (e.g., float32, float16, uint8).