fix(PackConstants): don't start new storage buffer if current one is still empty#23927
Open
schuermans-roofline wants to merge 1 commit intoiree-org:mainfrom
Open
Conversation
…still empty The PackConstant pass introduces a new buffer when a constant cannot be packed into the current buffer without exceeding the maximum size. However, if a constant is itself larger than the limit, it gets still added, but in a separate buffer. This change fixes a bug in the packing logic when a constant bigger than the limit is encountered when the current buffer is still empty. In this case, the current buffer stayed empty and the big constant got added to a new buffer. The empty buffer caused errors of size 0 buffers not being supported in following passes. This change avoids adding a new buffer is the current one is empty and thus avoids these errors. Signed-off-by: Stefan Schuermans <schuermans@roofline.ai>
schuermans-roofline
requested review from
MaheshRavishankar,
benvanik and
hanhanW
as code owners
Contributor
Author
|
This PR is a suggested fir for #23926 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PackConstants pass introduces a new buffer when a constant cannot be packed into the current buffer without exceeding the maximum size. However, if a constant is itself larger than the limit, it gets still added, but in a separate buffer.
This change fixes a bug in the packing logic when a constant bigger than the limit is encountered when the current buffer is still empty. In this case, the current buffer stayed empty and the big constant got added to a new buffer. The empty buffer caused errors of size 0 buffers not being supported in following passes or in the runtime. This change avoids adding a new buffer is the current one is empty and thus avoids these errors.