[Codegen] Plumb through dispatch_config for workgroup count computation.#23899
Merged
[Codegen] Plumb through dispatch_config for workgroup count computation.#23899
Conversation
hanhanW
requested review from
Groverkss,
MaheshRavishankar,
Max191,
Yu-Zhewen,
benvanik,
jtuyls,
krzysz00,
kuhar,
nirvedhmeshram and
qedawkins
as code owners
hanhanW
removed request for
Groverkss,
Yu-Zhewen,
benvanik,
jtuyls,
krzysz00,
kuhar and
nirvedhmeshram
Contributor
Author
|
It's ready for review, and it depends on
I'll send the cleanup for tests in a follow-up. |
hanhanW
force-pushed
the
users/hanhanW/propagate-dispatch-config
branch
from
c721068 to
a1af1fc
Compare
hanhanW
force-pushed
the
users/hanhanW/wire-dispatch-config
branch
from
2d58562 to
dac8e07
Compare
hanhanW
force-pushed
the
users/hanhanW/propagate-dispatch-config
branch
from
a1af1fc to
b9d437f
Compare
hanhanW
force-pushed
the
users/hanhanW/wire-dispatch-config
branch
from
06eda7c to
510258b
Compare
hanhanW
force-pushed
the
users/hanhanW/propagate-dispatch-config
branch
from
b9d437f to
68a91d7
Compare
hanhanW
force-pushed
the
users/hanhanW/wire-dispatch-config
branch
from
510258b to
02636ba
Compare
| if (failed( | ||
| lowerWorkgroupCountFromSliceOp(rewriter, funcOp, workgroupCount))) { | ||
|
|
||
| // Resolve the workgroup_count_from_slice in the dispatch_config op. |
Collaborator
There was a problem hiding this comment.
Can we just change the implementation of lowerWorkgroupCountrFromSliceOp to do this instead of removing that and inlining it?
Contributor
Author
There was a problem hiding this comment.
It only has a single user, so it is inlined. I restored the implementation to touch on dispatch_config op now,
hanhanW
force-pushed
the
users/hanhanW/propagate-dispatch-config
branch
from
af0abc2 to
37a5bff
Compare
hanhanW
force-pushed
the
users/hanhanW/wire-dispatch-config
branch
2 times, most recently
from
45f29b1 to
4613591
Compare
hanhanW
force-pushed
the
users/hanhanW/propagate-dispatch-config
branch
from
18b9823 to
21f658f
Compare
hanhanW
force-pushed
the
users/hanhanW/wire-dispatch-config
branch
from
870cc97 to
70e319a
Compare
Base automatically changed from
users/hanhanW/propagate-dispatch-config
to
main
March 27, 2026 17:41
Change ReconcileTranslationInfo and ResolveWorkgroupCountHints to run on ModuleOp and operate on dispatch_config ops. Wire CreateDispatchConfig and PropagateDispatchConfig into all backend pipelines. Signed-off-by: hanhanW <hanhan0912@gmail.com>
Signed-off-by: hanhanW <hanhan0912@gmail.com>
Signed-off-by: hanhanW <hanhan0912@gmail.com>
Signed-off-by: hanhanW <hanhan0912@gmail.com>
Signed-off-by: hanhanW <hanhan0912@gmail.com>
Signed-off-by: hanhanW <hanhan0912@gmail.com>
hanhanW
force-pushed
the
users/hanhanW/wire-dispatch-config
branch
from
70e319a to
312dfcf
Compare
MaheshRavishankar
approved these changes
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change ReconcileTranslationInfo and ResolveWorkgroupCountHints to run on ModuleOp and operate on dispatch_config ops. Wire CreateDispatchConfig and PropagateDispatchConfig into all backend pipelines.
It is a step towards #23642