fix refcount issue when adding/removing VIP group#594
Open
royhunter wants to merge 2 commits intoiqiyi:develfrom
Open
fix refcount issue when adding/removing VIP group#594royhunter wants to merge 2 commits intoiqiyi:develfrom
royhunter wants to merge 2 commits intoiqiyi:develfrom
Conversation
Contributor
royhunter
commented
Jun 21, 2020
royhunter
commented
- Increase VS's refcount when adding one RS
- Decrease VS's refcount when deleteing one RS
- Remove VS when its refcount is zero(No RS associated)
1. Increase VS's refcount when adding one RS 2. Decrease VS's refcount when deleteing one RS 3. Remove VS when its refcount is zero(No RS associated)
ywc689
added
pr/to-review-codes
Collaborator
|
@royhunter the commit "@royhunter |
Collaborator
|
@royhunter When you are free , please delete the commit of "enable coredump generation" on the PR, for the commit has been PR ed at #619 |
Contributor
|
Yes. I've tested that this PR (the refcount commit within it) fixes the keepalived issue #631 |
ywc689
added
pr/codes-need-change
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.