Skip to content

feat: bump FSharp.Analyzer.SDK to v0.36.0#168

Merged
nojaf merged 1 commit intoionide:mainfrom
MangelMaxime:bump-sdk-0.36.0
Mar 14, 2026
Merged

feat: bump FSharp.Analyzer.SDK to v0.36.0#168
nojaf merged 1 commit intoionide:mainfrom
MangelMaxime:bump-sdk-0.36.0

Conversation

@MangelMaxime
Copy link
Copy Markdown
Contributor

@MangelMaxime MangelMaxime commented Mar 13, 2026

Hello,

After updating to fsharp-analyzers version 0.36.0 in Fable repo, we are seeing issues with running the Ionide.Analyzers.

It seems caused by the Ionide.Analyzers not being built againt SDK version 0.36.0.

@nojaf
Copy link
Copy Markdown
Contributor

nojaf commented Mar 13, 2026

Please add a changelog entry for this so a new version gets released to NuGet.

@MangelMaxime
Copy link
Copy Markdown
Contributor Author

@nojaf I tried to mimic what other CHANGELOG commits were doing.

Hopefully, it was ok for me to set a version

Comment thread CHANGELOG.md Outdated
@@ -1,5 +1,11 @@
# Changelog

## 0.14.12 - 2026-03-13
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TheAngryByrd any ideas why minors are not used here?
None of this is binary compatible, so kinda weird to have a revision bump.
@MangelMaxime only played ball with what is already there, but weird nonetheless.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mainly because I forgot it's always binary incompatible

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want me to bump it to 0.15.0 ?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I personally would like that. Sorry for the nitpicking

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No problem done

@nojaf
Copy link
Copy Markdown
Contributor

nojaf commented Mar 13, 2026

Yep, thanks @MangelMaxime you did what I hoped for!

@nojaf nojaf merged commit 288919f into ionide:main Mar 14, 2026
5 checks passed
@nojaf
Copy link
Copy Markdown
Contributor

nojaf commented Mar 14, 2026

Thanks a bunch Maxime!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants