fix(ios): fix SPM package name not matching CLI CapApp-SPM generated name - #16
Conversation
|
@OS-pedrogustavobilro it looks like you previously approved the workflow run, do you mind letting it run again (I pushed an update)? It looks like the ios check used |
|
Thanks @OS-pedrogustavobilro, it looks like the checks are green now. What might be the next steps to get this merged? I'm not sure if you or @OS-martacarlos (original author) know why the package name was transposed. Was this possibly to allow importing and building against both packages at the same time? If so, did this require manually editing the |
|
Hey @terencehonles, it's all good here, I'll be merging this PR. To be frank, I'm not sure of the original reason, but it could have been a mishap, and only tested on existing apps with CocoaPods - A similar issue existed for geolocation and a similar PR was merged to fix it - ionic-team/capacitor-geolocation#34 Thank you for the contribution! |
|
Cool, thanks! Just making sure we could get this into the next release (so I don't have to manually make sure the Capacitor-SPM package is valid) |
|
@terencehonles v7.1.3 of the plugin was just released with this fix |
This change updates the SPM package name to match what the capacitor CLI generates for the
CapApp-SPMpackage.I'm not completely sure why the name was transposed when moved into this repository (original Package.swift), but my xcode project was failing to resolve the CapApp-SPM dependency (even after patching in #14), and eventually I edited the
CapApp-SPM/Package.swiftto depend on the productFilesystemCapacitorfrom the packageCapacitorFilesystem(despite the warnings not to edit the file), and I was able to finally resolve all the dependencies.This change will remove the need for manually editing the
CapApp-SPM/Package.swiftbecause the product will match the package name that the CLI uses.