Skip to content

fix(ios): fix SPM package name not matching CLI CapApp-SPM generated name - #16

Merged
OS-pedrogustavobilro merged 1 commit into
ionic-team:mainfrom
terencehonles:patch-1
Jul 25, 2025
Merged

fix(ios): fix SPM package name not matching CLI CapApp-SPM generated name#16
OS-pedrogustavobilro merged 1 commit into
ionic-team:mainfrom
terencehonles:patch-1

Conversation

@terencehonles

@terencehonles terencehonles commented Jun 30, 2025

Copy link
Copy Markdown
Contributor

This change updates the SPM package name to match what the capacitor CLI generates for the CapApp-SPM package.

I'm not completely sure why the name was transposed when moved into this repository (original Package.swift), but my xcode project was failing to resolve the CapApp-SPM dependency (even after patching in #14), and eventually I edited the CapApp-SPM/Package.swift to depend on the product FilesystemCapacitor from the package CapacitorFilesystem (despite the warnings not to edit the file), and I was able to finally resolve all the dependencies.

This change will remove the need for manually editing the CapApp-SPM/Package.swift because the product will match the package name that the CLI uses.

@terencehonles

Copy link
Copy Markdown
Contributor Author

@OS-pedrogustavobilro it looks like you previously approved the workflow run, do you mind letting it run again (I pushed an update)? It looks like the ios check used FilesystemCapacitor. Do you know anything about the renaming of the package?

@terencehonles

terencehonles commented Jul 25, 2025

Copy link
Copy Markdown
Contributor Author

Thanks @OS-pedrogustavobilro, it looks like the checks are green now. What might be the next steps to get this merged? I'm not sure if you or @OS-martacarlos (original author) know why the package name was transposed. Was this possibly to allow importing and building against both packages at the same time? If so, did this require manually editing the CapApp-SPM/Package.swift or were you not testing the SPM packages?

@OS-pedrogustavobilro
OS-pedrogustavobilro self-requested a review July 25, 2025 08:22
@OS-pedrogustavobilro

Copy link
Copy Markdown
Contributor

Hey @terencehonles, it's all good here, I'll be merging this PR.

To be frank, I'm not sure of the original reason, but it could have been a mishap, and only tested on existing apps with CocoaPods - A similar issue existed for geolocation and a similar PR was merged to fix it - ionic-team/capacitor-geolocation#34

Thank you for the contribution!

@OS-pedrogustavobilro
OS-pedrogustavobilro merged commit 18e93ad into ionic-team:main Jul 25, 2025
6 checks passed
@terencehonles

Copy link
Copy Markdown
Contributor Author

Cool, thanks! Just making sure we could get this into the next release (so I don't have to manually make sure the Capacitor-SPM package is valid)

@terencehonles
terencehonles deleted the patch-1 branch July 25, 2025 09:07
@OS-pedrogustavobilro

Copy link
Copy Markdown
Contributor

@terencehonles v7.1.3 of the plugin was just released with this fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants