Merged
Conversation
Sentry reported a `Keyerror: None`. Instead return a BadRequest (HTTP 400) now.
`get_page_list` is already in cache by default.
- ForumFeedSelectorForm: Use `TopicField` and `ForumField`
- Remove inherited field `mode` from `WikiFeedSelectorForm`,
as it should not be renderd in the HTML
- `app` is not used in the template anymore. Thus, it is removed
from the context
- Remove TOC
- The stylesheet `feedselector.less` is not needed anymore,
as django uses `<div>` for rendering the forms in HTML.
…form The code branch for the wiki was not used at all and thus removed.
Thus, eleminate the big if-else in the view.
It is only used inside the method.
For this extend TopicField to make it possibly reusable.
…arest The possible options/choices are already defined in the settings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see commit messages for details