feat: new arch support for banner , full screen ads and mobilesdk module on android#819
feat: new arch support for banner , full screen ads and mobilesdk module on android#819demon-sword wants to merge 5 commits intoinvertase:mainfrom
Conversation
|
To view this pull requests documentation preview, visit the following URL: docs.page/invertase/react-native-google-mobile-ads~819 Documentation is deployed and generated using docs.page. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #819 +/- ##
==========================================
- Coverage 43.72% 35.57% -8.15%
==========================================
Files 30 36 +6
Lines 549 658 +109
Branches 151 167 +16
==========================================
- Hits 240 234 -6
- Misses 309 424 +115 🚀 New features to boost your workflow:
|
|
Thank you for your contribution! Great to see someone working on new arch support for Android. Would be great if some more experienced Android developers can help test / review this @mikehardy @DoctorJohn @birdofpreyru @wjaykim |
|
Hello 👋, this PR has been opened for more than 2 months with no activity on it. If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing! You have 15 days until this gets closed automatically |
No way it has already been two months. I keep telling myself "I'll review this next weekend" 🫠 |
|
@DoctorJohn, please review this pr |
|
@DoctorJohn , please review this pr |
|
This does still need a look, but please please 🙏 interested folks, do not post +1s or "please review" etc. When you do that, you are requesting unpaid labor and being insistent about it. Please be self-aware and recognize that's rude. Review it yourself, do the QA yourself and post the results. Otherwise please be patient while others perform unpaid labor for you, yes? |
|
Or alternatively, sponsor the effort ;-). Always a positive way to go! |
|
Hello 👋, this PR has been opened for more than 2 months with no activity on it. If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing! You have 15 days until this gets closed automatically |
Description
This PR migrates key Android components to React Native’s New Architecture (TurboModules/Fabric) and updates documentation to reflect the current migration status.
Related issues
Release Summary
Android migration to New Architecture for core ads modules; documentation updated to reflect current status.
Checklist
AndroidiOSe2etests added or updated in__tests__e2e__jesttests added or updated in__tests__Test Plan
GoogleMobileAdsBannerViewNativeComponent) and manager (ReactNativeGoogleMobileAdsBannerAdViewManager).Think
react-native-google-mobile-adsis great? Please consider supporting the project with any of the below:Invertaseon Twitter