Open
Conversation
palkerecsenyi
force-pushed
the
new-tests
branch
from
15481bb to
b56d2cb
Compare
palkerecsenyi
force-pushed
the
new-tests
branch
from
15481bb to
b56d2cb
Compare
16 tasks
palkerecsenyi
force-pushed
the
new-tests
branch
from
b56d2cb to
8d8e975
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2
Rewrote unit tests for compatibility with new invenio-vcs package by making the tests provider-agnostic. This involved creating patches to emulate the low-level behaviour of provider SDKs (for GitHub and GitLab) based on an abstract interface. Future provider implementations will also need corresponding test mock implementations.
Generally renamed many references in the tests from invenio-github to invenio-vcs.
The tests should all currently be passing, but it's only possible to fully test them if you have all the PRs for the new module assembled. This is already done on the
masterbranch of https://github.com/palkerecsenyi/invenio-vcs-new for convenience.This commit on its own is UNRELEASABLE. We will merge multiple commits related to the VCS upgrade into the
masterbranch and then release them in one go once we have a fully ready prototype. At that point, we will create a squash commit.