fix: update password generation and remove passlib dependency#546
Open
Samk13 wants to merge 1 commit intoinveniosoftware:masterfrom
Open
fix: update password generation and remove passlib dependency#546Samk13 wants to merge 1 commit intoinveniosoftware:masterfrom
Samk13 wants to merge 1 commit intoinveniosoftware:masterfrom
Conversation
* Replace passlib's password generation with a custom function. * Update copyright information in hash.py and clean up unused imports.
10 tasks
| from cryptography.hazmat.backends import default_backend | ||
| from cryptography.hazmat.primitives.ciphers import Cipher, algorithms, modes | ||
| from passlib.utils.compat import str_to_uascii | ||
| from passlib.utils.handlers import GenericHandler, HasSalt, parse_mc2, render_mc2 |
Contributor
There was a problem hiding this comment.
can we remove this also with pythons stdlib?
Member
Author
There was a problem hiding this comment.
Would adding the dependency libpass to the requirements address this without changing this import? similar to inveniosoftware/flask-security-fork#91 or its not needed once merged?
Contributor
There was a problem hiding this comment.
yes, would work. i thought, since you replaced the pwd.genword function with an stdlib approach, it would be possible to replace the rest too.
adding libpass to flask-security-fork is enough, it doesn't have to be here too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
❤️ Thank you for your contribution!
Description
fix: ImportError: cannot import name 'str_to_uascii' from 'passlib.utils.compat' (unknown location)
Replace passlib's password generation with a custom function.
Update copyright information in hash.py and clean up unused imports.
Checklist
Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:
Frontend
Reminder
By using GitHub, you have already agreed to the GitHub’s Terms of Service including that: