integrate with invenio-app-rdm#13
Open
mairasalazar wants to merge 4 commits intoinveniosoftware:mainfrom
Open
Conversation
mairasalazar
force-pushed
the
allow-reading-file-from-path
branch
2 times, most recently
from
c03fbb6 to
77626f8
Compare
mairasalazar
changed the title
mairasalazar
force-pushed
the
allow-reading-file-from-path
branch
from
77626f8 to
ceddece
Compare
yashlamba
reviewed
Mar 12, 2026
mairasalazar
force-pushed
the
allow-reading-file-from-path
branch
2 times, most recently
from
497936d to
1195026
Compare
OliverGeneser
requested changes
Mar 13, 2026
| pdf_bytes = response.content | ||
| """Read a file and extract its text content using the specified extractor.""" | ||
| if settings.orcha_env in [Environment.LOCAL, Environment.DEV]: | ||
| with open(request.url, "rb") as f: |
Collaborator
There was a problem hiding this comment.
Maybe we should rename it to request.source as it can now be a locale file path which is not an URL.
Collaborator
Author
There was a problem hiding this comment.
I think we can keep it as it is since the local file path is a temporary thing for local dev
| return | ||
|
|
||
| except SQLAlchemyError as e: | ||
| print("Error in fetching from database (stream_workflow)", e) |
Collaborator
There was a problem hiding this comment.
Maybe we should move to using logging, so we get the stack traces + observability.
The button added in inveniosoftware/invenio-app-rdm#3355 allows triggering a workflow and passing a file path to it. In this case, the activity must read from a file uri instead of the url.
mairasalazar
force-pushed
the
allow-reading-file-from-path
branch
from
1195026 to
c80e161
Compare
mairasalazar
force-pushed
the
allow-reading-file-from-path
branch
from
c80e161 to
b923845
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
❤️ Thank you for your review!
This PR allows integrating the Orcha workflow with InvenioRDM by: