Skip to content

fix(h3): explicitly set compiler, messageResolver and localeFallbacker #182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MikeBellika wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(h3): explicitly set compiler, messageResolver and localeFallbacker #182

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions packages/h3/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,9 @@ import {
translate as _translate,
createCoreContext,
NOT_REOSLVED,
resolveValue,
compile,
fallbackWithLocaleChain,
// @ts-expect-error -- NOTE(kazupon): internal function
parseTranslateArgs
} from '@intlify/core'
Expand Down Expand Up @@ -198,6 +201,13 @@ export function defineIntlifyMiddleware<
const context = getEventContext<H3EventContext>(event)
context[SYMBOL_INTLIFY_LOCALE] = getLocaleDetector(event, intlify as CoreContext)
intlify.locale = context[SYMBOL_INTLIFY_LOCALE]

// @intlify/core has `sideEffects: false`. Some bundlers (like esbuild, used by cloudflare), may tree-shake the `register` calls in `core/src/index.ts`
// To get around this, we can explicitly set the compiler, messageResolver, and localeFallbacker here
intlify.messageCompiler = compile
intlify.messageResolver = resolveValue
intlify.localeFallbacker = fallbackWithLocaleChain

context[SYMBOL_INTLIFY] = intlify as CoreContext
}),
onResponse: onResponse((_, event) => {
Expand Down