Skip to content

fix(bg/paymentManager): improve interval precision & scaling logic#1347

Merged
sidvishnoi merged 2 commits intomainfrom
improve-continuous-payments-interval
Apr 6, 2026
Merged

fix(bg/paymentManager): improve interval precision & scaling logic#1347
sidvishnoi merged 2 commits intomainfrom
improve-continuous-payments-interval

Conversation

@sidvishnoi
Copy link
Copy Markdown
Member

Context

Discovered when writing an article.

Changes proposed in this pull request

  • Don't do ceil/Bigint too early, otherwise errors propagate/drift when multiplying.
  • Extract into a separate function and add unit tests
  • Nit: renamed Interval.duration to Interval.period

@sidvishnoi sidvishnoi requested a review from DarianM April 3, 2026 10:52
@github-actions github-actions bot added area: background Improvements or additions to extension background script area: tests Improvements or additions to tests labels Apr 3, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 3, 2026

Extension builds preview

Name Link
Latest commit 316b093
Latest job logs Run #23944109563
Chrome (1.37MB)Download
Firefox (1.37MB)Download
Safari (2.32MB)Download

@sidvishnoi sidvishnoi merged commit 738384d into main Apr 6, 2026
12 of 13 checks passed
@sidvishnoi sidvishnoi deleted the improve-continuous-payments-interval branch April 6, 2026 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: background Improvements or additions to extension background script area: tests Improvements or additions to tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants