Conversation
…es (#3834) * feat(token-instrospection): widen client spec to include jwk, add types * feat: update typegen package * fix: rm unused types * fix(auth): token info type * Revert "fix(auth): token info type" This reverts commit 1b28db2. * fix: resolve asset query issue in mock ase (#3840) --------- Co-authored-by: dragosp1011 <109967337+dragosp1011@users.noreply.github.com>
* feat: add jwk support to client/grant * fix: use grant error * fix: dont cast, use better types * chore: format * chore: dont unecessarily check kid against jwk * refactor: simplify types, logic for getting client field * refactor: move logic involving jwk/client into serivice * test: logic moved into grant service * fix: tests
…#3838) * feat(token-instrospection): widen client spec to include jwk, add types * feat: update typegen package * fix: rm unused types * fix(auth): token info type * Revert "fix(auth): token info type" This reverts commit 1b28db2. * feat(backend): handle JWK as possible client value in auth middleware --------- Co-authored-by: Blair Currey <12960453+BlairCurrey@users.noreply.github.com>
* feat(tests): integration tests for directed identity * chore: formatting
✅ Deploy Preview for brilliant-pasca-3e80ec canceled.
|
github-actions
bot
added
type: tests
🚀 Performance Test ResultsTest Configuration:
Test Metrics:
📜 Logs |
BlairCurrey
reviewed
Apr 8, 2026
Contributor
BlairCurrey
left a comment
BlairCurrey
left a comment
There was a problem hiding this comment.
Tested on Bruno and it looks good, just a couple of small suggestions. Thanks for closing this one out.
Contributor
There was a problem hiding this comment.
delete? looks like an erroneous folder
bruno/collections/Rafiki/scripts.js
Outdated
| @@ -1,4 +1,4 @@ | |||
| const { createHmac } = require('crypto') | |||
| const { createHmac, generateKeyPairSync, createPublicKey } = require('crypto') | |||
Contributor
There was a problem hiding this comment.
createPublicKey appears to be unused
| const { body } = ctx.request | ||
| const { grantService, interactionService, config, logger } = deps | ||
| if (!body.interact) { | ||
| if (!input.interact) { |
Contributor
There was a problem hiding this comment.
What about changing this to differentiate between missing and invalid (jwk) client? Noticed while trying to create an interactive grant with a jwk using the bruno collection - the error response is "missing required request field 'client'" but it might be important to clarify that it cant be a JWK. Something like:
if (!input.client) {
if (input.jwk) {
throw new GNAPServerRouteError(
400,
GNAPErrorCode.InvalidClient,
'JWK client identifier cannot be used for interactive grants'
)
}
throw new GNAPServerRouteError(
400,
GNAPErrorCode.InvalidClient,
"missing required request field 'client'"
)
}| { | ||
| client: ctx.client, | ||
| keyIdInSignature: keyId, | ||
| requestedRoute: `${ctx.client}/jwks.json`, |
Contributor
There was a problem hiding this comment.
Suggested change
| requestedRoute: `${ctx.client}/jwks.json`, | |
| requestedRoute: `${ctx.client.walletAddress}/jwks.json`, |
BlairCurrey
approved these changes
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
Context
This is the feature branch merge into main that will implement Directed Identity in Rafiki.
Checklist
fixes #numberuser-docslabel (if necessary)