fix(frontend): update Peer page maxPacketAmount description and link#3881
Open
Onyx2406 wants to merge 1 commit intointerledger:mainfrom
Open
fix(frontend): update Peer page maxPacketAmount description and link#3881Onyx2406 wants to merge 1 commit intointerledger:mainfrom
Onyx2406 wants to merge 1 commit intointerledger:mainfrom
Conversation
Update the maxPacketAmount field description on both the Create Peer and Edit Peer pages to specify that it is the maximum amount the operator is willing to accept from the peer, rather than the maximum that can be sent. Also update the link from the STREAM protocol RFC to the Rafiki admin user guide at rafiki.dev, which is a more stable URL. Closes interledger#3178
❌ Deploy Preview for brilliant-pasca-3e80ec failed. Why did it fail? →
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates the
maxPacketAmountfield description on the Create Peer and Edit Peer Admin UI pages per the TODOs in #3178:interledger.org/developers/rfcs/stream-protocol/torafiki.dev/admin/admin-user-guide/(more stable, less likely to move)Both the Create Peer (
peers.create.tsx) and Edit Peer (peers.$peerId.tsx) pages are updated.Changes
packages/frontend/app/routes/peers.create.tsxpackages/frontend/app/routes/peers.$peerId.tsxCloses #3178