Closed
Conversation
✅ Deploy Preview for styleguide-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
JonathanMatthey
force-pushed
the
jm/eslint-formatting
branch
3 times, most recently
from
93110b3 to
7b8aefa
Compare
- Add ESLint 9 and Prettier for consistent code formatting across docs repos - Configure ESLint with TypeScript and Astro support - Standardize lint and format commands across all repositories - Upgrade to ESLint 9 flat config format (eslint.config.js) - Update all ESLint and Prettier packages to latest versions - Add CI checks to enforce formatting standards
JonathanMatthey
force-pushed
the
jm/eslint-formatting
branch
from
c9d855a to
e57aafc
Compare
Contributor
Author
|
mdx files that go into starlight cant be linted / formatted with the plugins, so for now they're ignored. astro files are lint/formatted MDX files contain Starlight-specific constructs that aren't valid plain MDX: things like <$> wrappers, inline HTML comments inside components, raw JSON blocks, and JavaScript arrays declared at the top of an .mdx file. Prettier's MDX parser (even with prettier-plugin-astro) doesn't understand those patterns, so it throws syntax errors instead of formatting them. That causes pnpm lint to fail before ESLint even runs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
Context
DOCS-29: Add and enforce code formatting across the docs repos