feat: add collapsible sidebars component#77
Merged
melissahenderson merged 6 commits intomainfrom May 14, 2025
Merged
Conversation
Contributor
|
Thanks so much for tackling this! It's going to make such a big difference, it's been on my radar too. Am I the only one seeing the style breaks though?
Also the icons and their placement look like paging to me rather than full view buttons. I wonder if we could place them differently or maybe just use a simpler, single full view option so we can use a more common full view icon instead of having a directional one? |
Contributor
Author
eg.mp4@JoblersTune, @melissahenderson if you pull the latest version of this branch you should be able to see the version in the screenshare. |
huijing
commented
Apr 25, 2025
package.json
Outdated
| "@interledger/docs-design-system": "^0.6.2", | ||
| "astro": "^5.6.1", | ||
| "@astrojs/starlight": "^0.34.1", | ||
| "@interledger/docs-design-system": "^0.7.0", |
Contributor
Author
There was a problem hiding this comment.
Sites that need to use FullView need to update to 0.7.0 of dds.
✅ Deploy Preview for styleguide-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
JoblersTune
approved these changes
May 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
This PR adds a component that allows users to toggle both the left navigation sidebar or the right ToC side panel to make more space for the main content on wide viewports.
Although the issue was raised in the docs-design-system repo, this implementation is implemented using the Starlight component override approach rather than as an imported component that can be used within Starlight content.
In theory, could we change the docs-design-system to be able to handle component overrides via the Astro configuration like how a plugin would? Yes, of course. Anything is possible. Even rewriting complex COBOL systems in Java in 3 months, but after weighing the amount of effort required, I suggest going with this approach instead.
Context
Closes interledger/docs-design-system#41
Test locally
git pullgit checkout chj/add-collapsible-sidebarsbun run start