Skip to content

Conversation

@samplise
Copy link
Collaborator

@samplise samplise commented Dec 3, 2025

What changes were proposed in this pull request?

Add brain python implementation.

Why are the changes needed?

A python brain is easier to use.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Unit test.

@codecov
Copy link

codecov bot commented Dec 3, 2025

Codecov Report

❌ Patch coverage is 0% with 52 lines in your changes missing coverage. Please review.
✅ Project coverage is 15.11%. Comparing base (235cee6) to head (11da234).
⚠️ Report is 14 commits behind head on elastic_sync_training.

Files with missing lines Patch % Lines
dlrover/python/brain/client.py 0.00% 52 Missing ⚠️

❌ Your patch check has failed because the patch coverage (0.00%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage.
❌ Your project check has failed because the head coverage (15.11%) is below the target coverage (81.00%). You can increase the head coverage or adjust the target coverage.
❌ Your project check has failed because you have indirect coverage changes. Learn more about Unexpected Coverage Changes and reasons for indirect coverage changes.

❗ There is a different number of reports uploaded between BASE (235cee6) and HEAD (11da234). Click for more details.

HEAD has 3 uploads less than BASE
Flag BASE (235cee6) HEAD (11da234)
4 1
Additional details and impacted files
@@                    Coverage Diff                     @@
##           elastic_sync_training    #1668       +/-   ##
==========================================================
- Coverage                  80.27%   15.11%   -65.17%     
==========================================================
  Files                        225      225               
  Lines                      22150    22309      +159     
==========================================================
- Hits                       17780     3371    -14409     
- Misses                      4370    18938    +14568     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant