Merged
Conversation
Changes: - Add getDieId() accessor to PCM class in cpucounters.h - Add --die option parsing in pcm.cpp - Add die-level aggregation in print_output() (normal mode) - Add die-level aggregation in print_csv_header() and print_csv() (CSV mode) - Update print_help() with new option documentation - Update fuzz test to exercise the new code path --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: rdementi <25432609+rdementi@users.noreply.github.com>
* Add native PCIe metrics collection and export support - Move IPlatform::getPlatform() from pcm-pcie.cpp to pcm-pcie.h as inline so both pcm-pcie (CLI) and pcm-sensor-server (HTTP exporter) can instantiate platform objects without duplicating the factory logic - Add pcm-pcie-collector.h for Prometheus-style PCIe metrics collection - Expose IPlatform data accessors (getReadBw, getWriteBw, event, etc.) as public so PCIeCollector can read metrics externally - Extend pcm-sensor-server.cpp with PCIe metrics HTTP endpoints - Replace exit() with throw std::runtime_error() for server safety - Use override instead of virtual for compile-time correctness - Fix build warning in pcm-pcicfg.cpp
Change-Id: Id832e2a26b9c3b64a3f2452c34c8bd47128dee0a
opcm
approved these changes
Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.