[SYCL] Support 512 GRF size for CRI in sycl_ext_intel_grf_size#22707
Open
sarnex wants to merge 2 commits into
Open
[SYCL] Support 512 GRF size for CRI in sycl_ext_intel_grf_size#22707sarnex wants to merge 2 commits into
sarnex wants to merge 2 commits into
Conversation
Signed-off-by: Nick Sarnie <nick.sarnie@intel.com>
sarnex
changed the title
sarnex
marked this pull request as ready for review
July 21, 2026 19:36
uditagarwal97
approved these changes
Jul 21, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR un-embargoes and wires up support for requesting a 512-byte GRF size (for CRI) via the sycl_ext_intel_grf_size experimental extension, including runtime option propagation, documentation, and an end-to-end validation test.
Changes:
- Extend the
grf_size<...>property to accept512. - Propagate the 512-GRF request into backend compile options in the program manager.
- Add an E2E test and update the extension documentation to list CRI-supported values.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| sycl/test-e2e/DeviceCodeSplit/grf_512.cpp | New E2E test that exercises grf_size<512> and checks UR trace for the expected backend compile flag. |
| sycl/source/detail/program_manager/program_manager.cpp | Adds handling for sycl-grf-size == 512 to append a backend compile option. |
| sycl/include/sycl/ext/intel/experimental/grf_size_properties.hpp | Updates compile-time validation to allow grf_size<512>. |
| sycl/doc/extensions/experimental/sycl_ext_intel_grf_size.asciidoc | Documents CRI as supporting 128/256/512 GRF sizes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CRI is no longer embargoed so unembargo this feature.