[SYCL] Update the sycl_ext_intel_device_info Extension to Include XE Device Props#21826
[SYCL] Update the sycl_ext_intel_device_info Extension to Include XE Device Props#21826HPS-1 wants to merge 6 commits intointel:syclfrom
sycl_ext_intel_device_info Extension to Include XE Device Props#21826Conversation
…ce_exp_properties_t Signed-off-by: Hu, Peisen <peisen.hu@intel.com>
Signed-off-by: Hu, Peisen <peisen.hu@intel.com>
Signed-off-by: Hu, Peisen <peisen.hu@intel.com>
Signed-off-by: Hu, Peisen <peisen.hu@intel.com>
sycl_ext_intel_device_info Extension to Include XE Device Props
Signed-off-by: Hu, Peisen <peisen.hu@intel.com>
Signed-off-by: Hu, Peisen <peisen.hu@intel.com>
sarnex
left a comment
There was a problem hiding this comment.
lgtm but please have this reviewed by a second member of the runtime team, after merge is fine
| [source,c++] | ||
| ---- | ||
| namespace sycl::ext::intel::info::device { | ||
| struct xe_stacks_count { |
There was a problem hiding this comment.
| struct xe_stacks_count { | |
| struct xe_stack_count { |
I think you normally use the singular when describing the count of something.
| [source,c++] | ||
| ---- | ||
| namespace sycl::ext::intel::info::device { | ||
| struct eu_count_per_xe_core { |
There was a problem hiding this comment.
It seems like this should be named either eus_per_xe_core or execution_engines_per_xe_core to have the same naming pattern as the others. For example, you have xe_cores_per_cluster not xe_core_count_per_cluster.
Alternatively, you could name them all with the word "count" like xe_core_count_per_cluster.
| ---- | ||
|
|
||
| ''' | ||
|
|
There was a problem hiding this comment.
It seems like you are missing an equivalent to maxNumHwThreadsPerExecutionEngine:
maximal number of HW threads per Execution Engine
There was a problem hiding this comment.
AFAIK this is a duplicate of the existing gpu_hw_threads_per_eu info descriptor (https://github.com/intel/llvm/blob/9d89f0cdbb6c4762a77b2a15e7538e44213973da/sycl/doc/extensions/supported/sycl_ext_intel_device_info.asciidoc#intel-gpu-number-of-hardware-threads-per-eu), so I think it's unnecessary to add it again?
Level Zero is adding an extension to
zeDeviceGetPropertiesthat returns the following information (link to source code: https://github.com/intel/compute-runtime/blob/a852cba41fda2c0cf140e8a3e264f322e9e38911/level_zero/include/level_zero/ze_intel_gpu.h#L594) :Therefore, updating the
sycl_ext_intel_device_infoextension to add support to query these XE device properties.