Skip to content

[SYCL] Follow up fix after #21706#21800

Merged
sarnex merged 2 commits intointel:syclfrom
againull:follow_up_fix
Apr 17, 2026
Merged

[SYCL] Follow up fix after #21706#21800
sarnex merged 2 commits intointel:syclfrom
againull:follow_up_fix

Conversation

@againull
Copy link
Copy Markdown
Contributor

@againull againull commented Apr 17, 2026

Use #pragma message as it is supported by msvc/gcc/clang,

@againull againull requested a review from sarnex April 17, 2026 17:09
@againull againull requested a review from a team as a code owner April 17, 2026 17:09
Comment thread sycl/include/sycl/detail/defines.hpp Outdated
"No assumptions will be emitted due to no __builtin_assume available")
#else
#if defined(__cplusplus) && __cplusplus >= 202302L
#warning "No assumptions will be emitted due to no __builtin_assume available"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead could we use #pragma message in all cases? i think it works on msvc/gcc/clang

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, thx!

@againull againull requested a review from sarnex April 17, 2026 17:29
Copy link
Copy Markdown
Contributor

@sarnex sarnex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks i will merge once build ci passes

@sarnex sarnex merged commit c890902 into intel:sycl Apr 17, 2026
25 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants