Fix compilation issues due to Parser.cpp not fully generated#459
Open
robertogs2 wants to merge 1 commit into
Open
Fix compilation issues due to Parser.cpp not fully generated#459robertogs2 wants to merge 1 commit into
robertogs2 wants to merge 1 commit into
Conversation
Parser.cpp is produced by Ragel (Parser.rl) but was not correctly tied to the target that compiles it (hs_compile). This caused a race condition in parallel builds where compilation could start before generation completed, leading to empty or incomplete output. Attach the dependency to hs_compile to ensure correct build ordering. Signed-off-by: Roberto Gutierrez Sanchez <roberto.gutierrez@windriver.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We are hitting an error using Cmake 3.31, in which Parser.cpp is incomplete when the compilation for the hs library starts. This waits for the ragel to run to generate Parser.cpp before hitting compilation step.