feat: add data sources for listing GitHub App installations in an organization#2573
feat: add data sources for listing GitHub App installations in an organization#2573atilsensalduz wants to merge 6 commits intointegrations:mainfrom
Conversation
|
👋 Hey Friends, this pull request has been automatically marked as |
deiga
left a comment
There was a problem hiding this comment.
Hey 👋
Thank you for your contribution!
I've requested a few changes to make this fit into the provider even better :)
|
@atilsensalduz Please rebase and go through the comments |
Hey @deiga , apologies for the late reply. I somehow missed this PR. Thanks so much for the review! I’ve worked through your suggestions. |
|
Hi @deiga , I've changed the PR according to your suggestions. Could you please take a look again when you have time? Thanks in advance. |
github/data_source_github_organization_app_installations_test.go
Outdated
Show resolved
Hide resolved
github/data_source_github_organization_app_installations_test.go
Outdated
Show resolved
Hide resolved
|
@atilsensalduz could you please rebase this PR? |
stevehipwell
left a comment
There was a problem hiding this comment.
Thanks for the PR @atilsensalduz, I've added a couple of comments. Could you also add support for single_file_paths, created_at & updated_at.
…pp_installations data source Signed-off-by: atilsensalduz <atil.sensalduz@gmail.com>
Co-authored-by: Steve Hipwell <steve.hipwell@gmail.com>
Co-authored-by: Steve Hipwell <steve.hipwell@gmail.com>
Co-authored-by: Steve Hipwell <steve.hipwell@gmail.com>
…pp_installations data source Signed-off-by: atilsensalduz <atil.sensalduz@gmail.com>
|
@atilsensalduz this is looking good. Have you run the test locally, if so could you please attach a screenshot of the output? |
This PR introduces a new data source, github_app_installations, to enable listing all installed GitHub Apps within an organization. This addition enhances integration with existing resources such as github_app_installation_repository, providing better automation and management capabilities for GitHub App permissions.
What's New?
New Data Source: github_app_installations
Allows fetching all installed GitHub Apps in an organization:
data "github_organization_app_installations" "all_apps" {}Example Use Case:
This data source can be integrated with the github_app_installation_repository resource to manage app permissions on specific repositories:
API Reference: https://docs.github.com/en/rest/orgs/orgs?apiVersion=2022-11-28#list-app-installations-for-an-organization
Related Issue: #2570