Skip to content

CI build for mithril testing#3306

Open
disassembler wants to merge 48 commits intoinput-output-hk:developfrom
DripDropz:sl/test-plan
Open

CI build for mithril testing#3306
disassembler wants to merge 48 commits intoinput-output-hk:developfrom
DripDropz:sl/test-plan

Conversation

@disassembler
Copy link
Copy Markdown
Contributor

This PR ...

Todos

  • TODO

Screenshots

Testing Checklist


Review Checklist

Basics

  • PR assigned to the PR author(s)
  • input-output-hk/daedalus-dev and input-output-hk/daedalus-qa assigned as PR reviewers
  • If there are UI changes, Alexander Rukin assigned as an additional reviewer
  • PR has appropriate labels (release-vNext, feature/bug/chore, WIP)
  • PR link is added to a Jira ticket, ticket moved to In Review
  • PR is updated to the most recent version of the target branch (and there are no conflicts)
  • PR has a good description that summarizes all changes
  • PR contains screenshots (in case of UI changes)
  • CHANGELOG entry has been added to the top of the appropriate section (Features, Fixes, Chores) and is linked to the correct PR on GitHub
  • There are no missing translations (running yarn manage:translations produces no changes)
  • Text changes are proofread and approved (Jane Wild / Amy Reeve)
  • Japanese text changes are proofread and approved (Junko Oda)
  • Storybook works and no stories are broken (yarn storybook)
  • In case of dependency changes yarn.lock file is updated

Code Quality

  • Important parts of the code are properly commented and documented
  • Code is properly typed with typescript types
  • React components are split-up enough to avoid unnecessary re-renderings
  • Any code that only works in main process is neatly separated from components

Testing

  • New feature/change is covered by acceptance tests
  • New feature/change is manually tested and approved by QA team
  • All existing acceptance tests are still up-to-date
  • New feature/change is covered by Daedalus Testing scenario
  • All existing Daedalus Testing scenarios are still up-to-date

After Review

  • Update Slack QA thread by marking it with a green checkmark

AndrewWestberg and others added 30 commits February 10, 2026 08:22
Mithril provides snapshots in in-memory format, not LMDB. The conversion
step was incorrectly converting them TO LMDB format, which was unnecessary
and causing issues.

Skip the _convertSnapshot step entirely to use the snapshots as-is.
- Add --disable-setuid-sandbox and --no-sandbox flags to match production
- Disable React Refresh plugin which has Electron compatibility issues
- Disable React Refresh transform in SWC config

These changes fix runtime errors in the development environment.
This commit completes the nixpkgs-25.11 upgrade while maintaining
compatibility for components that require older toolchains.

Key changes:

- Separate nixpkgs (25.11) and nixpkgsJs (22.11-darwin) inputs
- Use pkgsJs.stdenv for Darwin builds to fix native module compilation
- Use pkgsJs for Windows GHC 8.10.7 (removed in nixpkgs-25.11)
- Use pkgsJs.darwin frameworks (apple_sdk_11_0 removed in 25.11)
- Set CXXFLAGS=-Wno-error via environment variables for Darwin builds
- Add direnv support with DAEDALUS_CLUSTER environment variable
- Make installers runnable with 'nix run' via meta.mainProgram

Root cause of Darwin build failures:
- Native modules (bigint-buffer, blake-hash, bufferutil, etc.) were
  incompatible with clang 21.1.7 from nixpkgs-25.11
- Using pkgsJs.stdenv (clang 11.1.0) provides the stable toolchain
  these modules were built and tested against

This approach allows us to:
- Use modern nixpkgs-25.11 for core infrastructure (flake-parts, etc.)
- Use stable nixpkgs-22.11-darwin for JavaScript/native module builds
- Avoid glibc version mismatches in native modules
- Successfully build installers for all platforms
david-profrontsolutions and others added 18 commits March 27, 2026 14:49
Update cardano-node from 10.5.4 to 10.6.2 and upgrade cardano-playground
to node-10.6.2-pre-config for compatibility.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants