Conversation
|
I checked this; I need to familiarize myself with the QIT suite, but LGTM in general. My only concern here is the dependency on the artifact produced by another workflow. Even if, in the future, this depends on a regular git tag pull, the changes needed shouldn't be too much. It would be a breaking change, though. |
|
The artifact is just a standard WP plugin zip, not some custom format, so it is not tied just to our workflow. QIT only works with plugin packages (zip), so pulling from git would not be useful here unless it's a very simple plugin without any build process. But either way adding other ways to retrieve the input would not be a breaking change I think. You would just need to add another parameter and check which one is set (or detect format of a single parameter). |
4b2c3d7 to
a810bb3
Compare
Please check if the PR fulfills these requirements
What kind of change does this PR introduce?
feature (new workflow)
The workflow for running the Woo Quality Insights Toolkit tests.