Conversation
- Fix log_config erasure bug: process_params.erase() was deleting user-provided log_config values instead of keeping them. Replaced with emplace() semantics. - Extract MakeHyperProcess() helper into hyper_process.hpp to deduplicate HyperProcess setup across reader.cpp, writer.cpp, and libpantab.cpp. - Fix throw "unreachable" (const char*) to throw std::logic_error, making exceptions catchable as std::exception. - Fix typo "unknownn" -> "unknown" in error message and fix misleading "ArrowAppendString failed" in BytesReadHelper. - Extract PrecisionLimit constant as kMaxNumericPrecision/kNumericVariantSize in numeric_gen.hpp, replacing 3 duplicated magic number definitions. - Refactor ReadHelper to use template method pattern: null checking is now handled once in the base class Read() method, with subclasses overriding ReadNonNull() instead. Eliminates ~60 lines of duplicated null checks. - Deduplicate timestamp switch in MakeInsertHelper via MakeTimestampInsertHelper template helper, reducing 8 near-identical branches to 4 one-line calls. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #xxx