Honor managed package config when installing by repo target#10
Closed
Honor managed package config when installing by repo target#10
Conversation
Agent-Logs-Url: https://github.com/inherelab/eget/sessions/f59b5377-eadc-423b-bdce-80136d35d04e Co-authored-by: inhere <5302062+inhere@users.noreply.github.com>
Agent-Logs-Url: https://github.com/inherelab/eget/sessions/f59b5377-eadc-423b-bdce-80136d35d04e Co-authored-by: inhere <5302062+inhere@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix
Honor managed package config when installing by repo target
May 6, 2026
eget not respecting eget.toml during package installationThere was a problem hiding this comment.
Pull request overview
This PR fixes install-option resolution so eget install <owner>/<repo> correctly reuses an existing managed package entry ([packages.<name>]) when that entry’s repo matches the requested repo target. This makes repo-based installs inherit the same package-specific defaults (e.g., target, tag) that previously only applied when installing by package name.
Changes:
- Extend install target lookup to match managed packages by
packages.<name>.repowhen the CLI target is a repo. - Reuse the matched package section when merging install options, so repo installs inherit managed package settings.
- Add a regression test ensuring repo installs prefer managed package
targetoverglobal.target.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| internal/app/install.go | Adds repo-to-managed-package matching and uses the matched package section when resolving install options. |
| internal/app/install_test.go | Adds a regression test verifying managed package config is honored when installing by repo target. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
eget install <owner>/<repo>was bypassingpackages.<name>config entries even when that repo was already declared ineget.toml. As a result, installs could skip configured package/global defaults such as the target directory.Install request resolution
packages.<name>.repo, not just the package name.Config application
target,tag, and other merged defaults apply consistently for both:eget install gomieget install babarot/gomiRegression coverage
babarot/gomiuses the managed package config and does not fall back to the global target.Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
https://api.github.com/repos/babarot/gomi/releases/latest/tmp/eget-test /tmp/eget-test install --quiet babarot/gomi(http block)If you need me to access, download, or install something from one of these locations, you can either: