Added explicit utf-8 encoding to two steps where html is written#18
Open
awight-watershed wants to merge 1 commit into
Open
Added explicit utf-8 encoding to two steps where html is written#18awight-watershed wants to merge 1 commit into
awight-watershed wants to merge 1 commit into
Conversation
…ile. The utf-8 encoding is required on line 635 because that HTML file has the angstrom symbol, which can't be encoded in ASCII. The change on line 583 was not strictly necessary in my tests, since that HTML file lacks any non-ASCII characters, but for consistency's sake I thought we should have both writes be in utf-8, especially if that other HTML file is ever changed in the future.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The utf-8 encoding is required on line 635 because that HTML file has the angstrom symbol, which can't be encoded in ASCII. The change on line 583 was not strictly necessary in my tests, since that HTML file lacks any non-ASCII characters, but for consistency's sake I thought we should have both writes be in utf-8, especially if that other HTML file is ever changed in the future.