This repository was archived by the owner on Mar 10, 2021. It is now read-only.
Slugify and replace space with hyphens in page path#74
Closed
manusajith wants to merge 1 commit intoinfinitered:masterfrom
Closed
Slugify and replace space with hyphens in page path#74manusajith wants to merge 1 commit intoinfinitered:masterfrom
manusajith wants to merge 1 commit intoinfinitered:masterfrom
Conversation
Signed-off-by: Manu S Ajith <neo@codingarena.in>
Member
Member
|
@manusajith I missed this, sorry about that! We already have some code to handle slugification, so we should unify the two: thesis-phoenix/lib/thesis/render.ex Lines 94 to 99 in a895d18 Otherwise, 👍 on this change. Could you also write a test or two? |
Member
|
@robinheinze and/or @mlaco Let's chat about this at some point. |
Contributor
|
Closing in favor of #111 Thanks for the help, @manusajith! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref: #67
This change replaces spaces in slug with hyphens, but the bug still remains, as the redirection is handled in the front end now. We should either update backend to return the updated changeset or should update frontend with the same logic to replace spaces with hyphens