Open
Conversation
* Update brakeman from 8.0.2 to 8.0.4 (required by scan_ruby step) * Add void to createInertiaApp on ssr entrypoint (required by lint_js step)
Required by scan_ruby ci step due to vulnerabilities
Collaborator
|
Thanks @nerlichman! Do you think we should go further, drop |
Contributor
Author
|
Yeah, sounds great! I'll also need to guard if (typeof localStorage !== "undefined") {
initializeTheme()
}I enabled SSR to test and found a few errors. First in the vite config, setting this results in ssr: {
// prebuilds ssr.js so we can drop node_modules from the resulting container
noExternal: true,
},In order not to remove this, the solution I found was doing the following: export default defineConfig(({ command }) => ({
ssr: command === "build"
? { noExternal: true } // prebuild ssr.js so we can drop node_modules from the container
: undefined,
plugins: [
// ...But I'm not sure if this is correct.
What do you think? |
1f4d426 to
97f3ad3
Compare
This addresses the error: SSR ERROR window is not defined Source: hooks/use-mobile.ts:5:13
7cee9de to
e690ecd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
@inertiajs/reactfrom v2 to v3 andinertia_railsgem to~> 3.19.@inertiajs/viteplugin.<title inertia>to<title data-inertia>.use_data_inertia_head_attributeto Rails initializer.voidto ssr entrypoint (required bylint_jsstep).scan_rubyci step.