Revert "Allow DB connections to refresh credentials (#646)"#674
Open
Revert "Allow DB connections to refresh credentials (#646)"#674
Conversation
This reverts commit 1d6959e. Signed-off-by: Cole Kennedy <cole@testifysec.com>
colek42
force-pushed
the
revert/db-cred-rotation
branch
from
9ef88ee to
4fd6880
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Revert: Allow DB connections to refresh credentials (#646)
Summary
This PR reverts commit 1d6959e ("Allow DB connections to refresh credentials (#646)") which was merged from
feat/db-cred-rotation.Reason for Revert
The original PR included modules that were imported from a personal repository. I missed them on my review. These dependencies need to be properly sourced before this feature can be re-implemented.
What this reverts
pkg/metadatastorage/sqlstore/utils.goNext Steps
Related
revert/db-cred-rotation