fix(#560): Fix MYSQL Conn string requirements#565
Open
hibare wants to merge 3 commits intoin-toto:mainfrom
Open
fix(#560): Fix MYSQL Conn string requirements#565hibare wants to merge 3 commits intoin-toto:mainfrom
hibare wants to merge 3 commits intoin-toto:mainfrom
Conversation
fba28e1 to
c163d80
Compare
jkjell
reviewed
Jun 2, 2025
kairoaraujo
reviewed
Jun 4, 2025
Collaborator
kairoaraujo
left a comment
There was a problem hiding this comment.
Hi @hibare,
Thank you for the PR.
Can we have just a unit test to avoid any regression in the future?
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #565 +/- ##
==========================================
- Coverage 82.40% 1.36% -81.04%
==========================================
Files 10 125 +115
Lines 358 34054 +33696
==========================================
+ Hits 295 465 +170
- Misses 43 33522 +33479
- Partials 20 67 +47 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Author
@kairoaraujo Added unit tests. Please let me know if anything is required. |
Signed-off-by: Shubham Hibare <shubham@hibare.in>
Signed-off-by: Shubham Hibare <shubham@hibare.in>
5 tasks
manzil-infinity180
suggested changes
Oct 24, 2025
Co-authored-by: Rahul Vishwakarma <rahulvs2809@gmail.com> Signed-off-by: Shubham Hibare <20609766+hibare@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
This adds a function to ensure the connection string has tcp() wrapped around host part. This is required by the go-sql-driver but not required by atlas for DB migration,
Which issue(s) this PR fixes (optional)
(optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when the PR gets merged)*Fixes #560
Acceptance Criteria Met
Special notes for your reviewer: