Skip to content

fix(#560): Fix MYSQL Conn string requirements#565

Open
hibare wants to merge 3 commits intoin-toto:mainfrom
hibare:main
Open

fix(#560): Fix MYSQL Conn string requirements#565
hibare wants to merge 3 commits intoin-toto:mainfrom
hibare:main

Conversation

@hibare
Copy link

@hibare hibare commented Jun 2, 2025

What this PR does / why we need it

This adds a function to ensure the connection string has tcp() wrapped around host part. This is required by the go-sql-driver but not required by atlas for DB migration,

Which issue(s) this PR fixes (optional)

(optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged)*

Fixes #560

Acceptance Criteria Met

  • Docs changes if needed
  • Testing changes if needed
  • All workflow checks passing (automatically enforced)
  • All review conversations resolved (automatically enforced)
  • DCO Sign-off

Special notes for your reviewer:

@hibare hibare force-pushed the main branch 2 times, most recently from fba28e1 to c163d80 Compare June 2, 2025 10:39
Copy link
Collaborator

@kairoaraujo kairoaraujo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @hibare,

Thank you for the PR.
Can we have just a unit test to avoid any regression in the future?

@codecov
Copy link

codecov bot commented Jun 4, 2025

Codecov Report

Attention: Patch coverage is 75.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 1.36%. Comparing base (a035c62) to head (cdd51b8).
Report is 353 commits behind head on main.

Files with missing lines Patch % Lines
pkg/metadatastorage/sqlstore/client.go 75.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #565       +/-   ##
==========================================
- Coverage   82.40%   1.36%   -81.04%     
==========================================
  Files          10     125      +115     
  Lines         358   34054    +33696     
==========================================
+ Hits          295     465      +170     
- Misses         43   33522    +33479     
- Partials       20      67       +47     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@hibare
Copy link
Author

hibare commented Jun 17, 2025

Hi @hibare,

Thank you for the PR. Can we have just a unit test to avoid any regression in the future?

@kairoaraujo Added unit tests. Please let me know if anything is required.

hibare added 2 commits June 24, 2025 11:13
Signed-off-by: Shubham Hibare <shubham@hibare.in>
Signed-off-by: Shubham Hibare <shubham@hibare.in>
Co-authored-by: Rahul Vishwakarma <rahulvs2809@gmail.com>
Signed-off-by: Shubham Hibare <20609766+hibare@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Inconsistent MYSQL connection string requirements

4 participants